Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy_dev: Pass stderr to CommandFailed #6656

Merged
merged 1 commit into from Jan 31, 2021

Conversation

phansch
Copy link
Member

@phansch phansch commented Jan 31, 2021

This improves error reporting when running rustfmt fails for some reason, as seen on Zulip. It will now include the stderr output in the CliError::CommandFailed error.

changelog: none

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 31, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 31, 2021

📌 Commit da26b21 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jan 31, 2021

⌛ Testing commit da26b21 with merge ed11274...

@bors
Copy link
Collaborator

bors commented Jan 31, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing ed11274 to master...

@bors bors merged commit ed11274 into rust-lang:master Jan 31, 2021
@phansch phansch deleted the command-failed-print-stderr branch January 31, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants